search

tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Skip TLS certificate verification for e2e #530

Closed sayan-biswas closed 1 year ago

sayan-biswas commented 1 year ago

Changes

Allows the test to skip TLS verification when it's not possible to produce valid certificates. In case it is required to run the e2e test against tekton-results service exposed.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

NONE
enarha commented 1 year ago

/lgtm

tekton-robot commented 1 year ago

@avinal: changing LGTM is restricted to collaborators

In response to [this](https://github.com/tektoncd/results/pull/530#pullrequestreview-1539132028): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment