search

tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Remove TLS hostname override #536

Closed sayan-biswas closed 1 year ago

sayan-biswas commented 1 year ago

Changes

Removes the TLS hostname override option and disables TLS verification for the internal gRPC client used for proxying incoming request to gRPC server.

Fixes #521

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

ACTION REQUIRED: Config option, TLS_HOSTNAME_OVERRIDE is removed as the internal gRPC proxy client doesn't need to reverify the TLS.
adambkaplan commented 1 year ago

This should have an ACTION REQUIRED prefix on the release note. This introduces a "breaking" change by removing a deployment configuration option.

sayan-biswas commented 1 year ago

This should have an ACTION REQUIRED prefix on the release note. This introduces a "breaking" change by removing a deployment configuration option.

Updated release note.

enarha commented 1 year ago

/approve

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enarha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [enarha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment