tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Bump tkn-results to use latest version of results #550

Closed avinal closed 1 year ago

avinal commented 1 year ago

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

- tkn-results bumped to use v0.7.0 of results
- tkn-results Go version bumped to go1.19
tekton-robot commented 1 year ago

Hi @avinal. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
avinal commented 1 year ago

I have a feeling that it would be better to break it into two commits or even two PRs. Please let me know.

adambkaplan commented 1 year ago

@avinal two commits makes the most sense:

adambkaplan commented 1 year ago

/ok-to-test

avinal commented 1 year ago

I did not run go mod vendor for tkn-results. It is currently not in the main tree and many dependencies will be duplicated. Filed #551 for moving in tree.

avinal commented 1 year ago

/kind misc

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
avinal commented 1 year ago

Hey Vincent, we are holding this PR until other CLI prs are merged. I will rebase as soon they are meregd.

avinal commented 1 year ago

I have tested the bump with the latest changes in tkn-results, everything is working as expected. PTAL