Closed avinal closed 1 year ago
Hi @avinal. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
I have a feeling that it would be better to break it into two commits or even two PRs. Please let me know.
@avinal two commits makes the most sense:
go mod tidy && go mod vendor
/ok-to-test
I did not run go mod vendor
for tkn-results
. It is currently not in the main tree and many dependencies will be duplicated. Filed #551 for moving in tree.
/kind misc
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hey Vincent, we are holding this PR until other CLI prs are merged. I will rebase as soon they are meregd.
I have tested the bump with the latest changes in tkn-results, everything is working as expected. PTAL
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes