tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

[CLI] Support passing of Service Account to tkn-results #575

Closed khrm closed 1 year ago

khrm commented 1 year ago

The User can pass the flag --sa for serviceaccount name and --sa-ns for serviceaccount namespace. Latter is optional. If not given, then the namespace from the current context is assumed.

Fixes #576

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

The User can pass the flag --sa for serviceaccount name and --sa-ns for serviceaccount namespace. Latter is optional. If not given, then the namespace from the current context is assumed.
khrm commented 1 year ago

/kind feature

khrm commented 1 year ago

@enarha @avinal @sayan-biswas @adambkaplan Can you review this asap? Part of milestone v0.8.0

khrm commented 1 year ago

All flags seem to be broken in the main.

khrm commented 1 year ago

@avinal Can you test this pr now?

khrm commented 1 year ago

@enarha @sayan-biswas Let's merge this pr also. @avinal Tested this.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 1 year ago

/lgtm