tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

[CLI] Add insecure flag to make insecure GRPC TLS call #577

Closed khrm closed 1 year ago

khrm commented 1 year ago

Changes

Fixes #458

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Add `--insecure` flag to make insecure GRPC TLS calls.
khrm commented 1 year ago

/kind feature

khrm commented 1 year ago

@enarha @avinal @sayan-biswas @adambkaplan Can you review this asap? Part of milestone v0.8.0

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, sayan-biswas, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [sayan-biswas,vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sayan-biswas commented 1 year ago

/lgtm