tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

add instructions for handling large log files #588

Closed avinal closed 1 year ago

avinal commented 1 year ago

Changes

Signed-off-by: Avinal Kumar avinal@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

none
avinal commented 1 year ago

/kind documentation /ok-to-test

avinal commented 1 year ago

cc: @khrm @enarha @sayan-biswas

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [khrm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adambkaplan commented 1 year ago

/lgtm

This suggests that we need a better mechanism for serving large logs as a stream of text. Requiring all of the data to be streamed before base64 decoding will not scale to mutli-gigabyte log files.