tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Add E2E test for GCS log storage #591

Closed khrm closed 1 year ago

khrm commented 1 year ago

Changes

Fixes #593

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 1 year ago

To see whether there's a flake in this or not /retest pull-tekton-results-integration-tests

tekton-robot commented 1 year ago

@khrm: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/tektoncd/results/pull/591#issuecomment-1706842223): >To see whether there's a flake in this or not >/retest pull-tekton-results-integration-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 1 year ago

/test pull-tekton-results-integration-tests

khrm commented 1 year ago

/test pull-tekton-results-integration-tests

khrm commented 1 year ago

/test pull-tekton-results-integration-tests

khrm commented 1 year ago

/test pull-tekton-results-integration-tests

khrm commented 1 year ago

/test pull-tekton-results-integration-tests

khrm commented 1 year ago

I have tested this multiple time and can see that there's no flake.

khrm commented 1 year ago

After merging this, we can do the release. @enarha

khrm commented 1 year ago

Job history. https://prow.tekton.dev/pr-history/?org=tektoncd&repo=results&pr=591

The relevant one is integration tests. The last few runs have been successful continuously.

/test pull-tekton-results-integration-tests

enarha commented 1 year ago

/lgtm