tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Fix release script GCS bucket for the release.yaml #596

Closed khrm closed 1 year ago

khrm commented 1 year ago

Fixes #595

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

NONE
khrm commented 1 year ago

@enarha This should fix the #595 /release-note-none

tekton-robot commented 1 year ago

@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/596#issuecomment-1708098006): >@enarha This should fix the #595 >/release-note-none Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 1 year ago

/test pull-tekton-results-integration-tests

enarha commented 1 year ago

/approve

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enarha, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [enarha,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sayan-biswas commented 1 year ago

/lgtm