piyush-garg commented 1 year ago

config file not present should not throw error like 2023/09/12 17:28:58 error setting up flags and configConfig File "results" Not Found in "[/home/pgarg/.config/tkn]"

/kind bug

These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Tested your changes locally (if this is a code change)
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

config file not present should be handled

avinal commented 1 year ago

/release-note-none /ok-to-test

tekton-robot commented 1 year ago

@avinal: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/604#issuecomment-1715669552): >/release-note-none >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

khrm commented 1 year ago

/lgtm

khrm commented 1 year ago

/cherry-pick release-v0.8.x

tekton-robot commented 1 year ago

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.8.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/results/pull/604#issuecomment-1716419455): >/cherry-pick release-v0.8.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tekton-robot commented 1 year ago

@khrm: new pull request created: #606

In response to [this](https://github.com/tektoncd/results/pull/604#issuecomment-1716419455): >/cherry-pick release-v0.8.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tektoncd / results

config file not present should be handled #604

Release Notes