tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Remove Config Values as Env var in API server #608

Closed khrm closed 9 months ago

khrm commented 1 year ago

Move these config values to the configmap so that changing configmap configures the value. Fixes #607

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

DB_NAME and DB_HOST should be configurable via configmap.
khrm commented 1 year ago

/assign @enarha @avinal

khrm commented 1 year ago

/test pull-tekton-results-integration-tests

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 1 year ago

/retest

khrm commented 1 year ago

@xinredhat Go coverage job was fixed.

avinal commented 1 year ago

/retest

khrm commented 11 months ago

@enarha Let's merge this.

khrm commented 9 months ago

@enarha Let's merge this for release also.

khrm commented 9 months ago

/kind misc