Closed ramessesii2 closed 11 months ago
Hi @ramessesii2. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
cc @sayan-biswas
/ok-to-test
@ramessesii2 personally I like we have the name and the namespace as separate fields as having the combo in "knative.dev/key" is less obvious. I agree the kind is probably redundant as it's quite obvious from the "results.tekton.dev/kind" field. That's IMO. Having said that, I do not have strong objection, so if others prefer the shorter records, then OK with me.
@enarha @avinal ~~given your reviews, I propose having the keys 'namespace' & 'name' uniform throughout the watcher logs. Right now, it's sporadic.
Also, we seem to agree having "results.tekton.dev/kind" is enough for marking a kind
in logs, so I'll get rid of kind
keys.~~
Removing changes related to redundant fields in logs.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: avinal, enarha
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/kind misc
/kind cleanup
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes