tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

fix subgrouping not working in CEL filters #627

Closed avinal closed 11 months ago

avinal commented 12 months ago

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

fix subgroups not working in CEL filtering
avinal commented 12 months ago

/kind bug /ok-to-test

tekton-robot commented 12 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/cel2sql/interpreter.go 73.3% 74.0% 0.7
tekton-robot commented 12 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/cel2sql/interpreter.go 73.3% 74.0% 0.7
khrm commented 12 months ago

/retest-required

avinal commented 12 months ago

I was discussing with Sayan about adding more random tests to the cel2sql interpreter. We may look for a fuzzing test. Let's discuss this on WG call.

alan-ghelardi commented 12 months ago

/approve

tekton-robot commented 12 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alan-ghelardi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [alan-ghelardi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 12 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/cel2sql/interpreter.go 73.3% 74.0% 0.7