Closed sayan-biswas closed 11 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/logs/writer.go | 85.7% | 80.0% | -5.7 |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/logs/writer.go | 85.7% | 84.8% | -0.9 |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/logs/writer.go | 85.7% | 84.8% | -0.9 |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/logs/writer.go | 85.7% | 84.8% | -0.9 |
/test pull-tekton-results-integration-tests
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: avinal, khrm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/approve Tested, it works as expected. Tested on very large log files too (~100k lines)
Click here to see tests Few questions:
- should the tkn-results update be included in this PR?
- Docs for handling large logs be updated/deleted?
I don't think tkn-results will need any change. I'll check and update in this PR if required. The document for handling large logs will not be relevant anymore, I can delete it as a part of this PR.
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/logs/writer.go | 85.7% | 84.8% | -0.9 |
/approve Tested, it works as expected. Tested on very large log files too (~100k lines)
Click here to see tests Few questions:
- should the tkn-results update be included in this PR?
- Docs for handling large logs be updated/deleted?
Removed doc "handling large logs"
Closes #601
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes