search

tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Subject Access Review in API RBAC is not considering Groups and Extra #634

Closed sayan-biswas closed 11 months ago

sayan-biswas commented 11 months ago

Expected Behaviour

The API server RBAC should include the Groups and Extra while doing a Subject Access Review

Actual Behaviour

Subject Access Review doesn't consider the Groups and Extra.

Additional Info

Hardcoded value and empty map. Ideally should be taken from TokenReview status.

https://github.com/tektoncd/results/blob/0aa7ce4900d905dfac265bd8542e99bda451d4c7/pkg/api/server/v1alpha2/auth/rbac.go#L122-L123