tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Fix SAR groups and Extra #635

Closed sayan-biswas closed 11 months ago

sayan-biswas commented 11 months ago

Fixes #634

Changes

Add Groups and Extra in the Subject Access Review in RBAC processing.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Fix authorization check to include the Groups and Extras from the token access review.
adambkaplan commented 11 months ago

@sayan-biswas I added a release note - changes to behavior like this should always include a release note.

tekton-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 11 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/auth/rbac.go 73.3% 75.0% 1.7