tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Add support for database SSL verification and encryption #658

Closed enarha closed 10 months ago

enarha commented 10 months ago

Changes

A configuration option for setting database SSL mode existed, but there was no support for using custom CA certificates. A new option was added to allow the user to set path for CA cert to be used for validation and encryption.

/kind feature

fixes #531

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

A new configuration option DB_SSLROOTCERT was added with a default value of empty string. You do not need to set that value, unless you want to enforce TLS connection to your database and use custom CA certificate for it.
tekton-robot commented 10 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 12.1% 11.9% -0.2
tekton-robot commented 10 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 12.1% 11.9% -0.2
tekton-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, iainsproat, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal,sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 10 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 12.1% 11.9% -0.2
avinal commented 10 months ago

Got approval from all the reviewers. Moving forward /lgtm