tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Use best practices for namespaces in kustomization #661

Closed drGrove closed 10 months ago

drGrove commented 10 months ago

Changes

This change will allow users that reference these kustomizations to more easily run this in any namespace of their choosing. Whenever namespaces are included in base resources, any patches also require the original namespace to be referenced in said patch.

In regards to ClusterRoles/ClusterRoleBindings, kustomize will automatically add the namespace where it is required automatically.

To allow the release artifacts to continue to set the tekton-pipelines namespace in it's output, the namespace has been set specifically for the release kustomziation.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

NONE
linux-foundation-easycla[bot] commented 10 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

tekton-robot commented 10 months ago

Hi @drGrove. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
drGrove commented 10 months ago

/kind cleanup

enarha commented 10 months ago

/ok-to-test

james-callahan commented 10 months ago

Note to self: can strip out https://github.com/james-callahan/tekton-kustomize/blob/0945c35f94055e507cc02cedc7a80c3ca84bb323/results/kustomization.yaml#L11C12-L11C12 once this is merged/released.

tekton-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, avinal, james-callahan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan,avinal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 8 months ago

/kind misc