Closed drGrove closed 10 months ago
Hi @drGrove. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/kind cleanup
/ok-to-test
Note to self: can strip out https://github.com/james-callahan/tekton-kustomize/blob/0945c35f94055e507cc02cedc7a80c3ca84bb323/results/kustomization.yaml#L11C12-L11C12 once this is merged/released.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adambkaplan, avinal, james-callahan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/kind misc
Changes
This change will allow users that reference these kustomizations to more easily run this in any namespace of their choosing. Whenever namespaces are included in base resources, any patches also require the original namespace to be referenced in said patch.
In regards to ClusterRoles/ClusterRoleBindings, kustomize will automatically add the namespace where it is required automatically.
To allow the release artifacts to continue to set the tekton-pipelines namespace in it's output, the namespace has been set specifically for the release kustomziation.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes