Closed drGrove closed 10 months ago
/kind cleanup
Hi @drGrove. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adambkaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
While the SERVER_PORT is configurable and theoretically someone could set that to a port <1024, I think it's a good change. /lgtm
/kind misc
Changes
NET_BIND_SERVICE is only necessary for applications the require access to privileged ports, eg. ports under 1024. Since we are using ports that any user may listen on, this is unnecessary
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes