tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Drop NET_BIND_SERVICE cap as it isn't necessary #663

Closed drGrove closed 10 months ago

drGrove commented 10 months ago

Changes

NET_BIND_SERVICE is only necessary for applications the require access to privileged ports, eg. ports under 1024. Since we are using ports that any user may listen on, this is unnecessary

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Drop NET_BIND_SERVICE capability from results deployments.
drGrove commented 10 months ago

/kind cleanup

tekton-robot commented 10 months ago

Hi @drGrove. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
enarha commented 10 months ago

/ok-to-test

tekton-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 10 months ago

While the SERVER_PORT is configurable and theoretically someone could set that to a port <1024, I think it's a good change. /lgtm

khrm commented 8 months ago

/kind misc