tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Logs not forwarded when PipelineRun status is "Completed" #664

Closed sayan-biswas closed 10 months ago

sayan-biswas commented 10 months ago

Expected Behaviour

Logs should be captured when PipelineRun is Successful or Failed. But as per the PipelineRun API, status Completed is a successful run with skipped steps and logs should be captured.

Actual Behaviour

Logs are not captured for PipelineRun status Completed

Condition checked

https://github.com/tektoncd/results/blob/b143afec571711b7ea1328efe5a1c0e6dc826a02/pkg/watcher/reconciler/dynamic/dynamic.go#L276

PipelineRun API

https://github.com/tektoncd/pipeline/blob/89ac5c2cbfeb8cd664de9db9ddd80f32698eb30e/pkg/apis/pipeline/v1beta1/pipelinerun_types.go#L349-L352