tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Add owner references check optional in watcher #672

Closed sayan-biswas closed 11 months ago

sayan-biswas commented 12 months ago

As per discussion in #648

Changes

This PR makes the owner reference check in watcher optional.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

"check_owner" command line flag allows the Owner References check to be optional while deleting resources.
tekton-robot commented 12 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 66.9% 68.3% 1.4
sayan-biswas commented 12 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 12 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 66.9% 68.3% 1.4
tekton-robot commented 12 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 66.9% 68.3% 1.4
tekton-robot commented 11 months ago

@Roming22: changing LGTM is restricted to collaborators

In response to [this](https://github.com/tektoncd/results/pull/672#pullrequestreview-1750561181): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
enarha commented 11 months ago

/approve /lgtm on behalf of @Roming22

avinal commented 11 months ago

/approve

tekton-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, enarha, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal,enarha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
avinal commented 11 months ago

/lgtm