tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Adds PostgreSQL Database Table Schema to Configuration #677

Open chriscannon opened 11 months ago

chriscannon commented 11 months ago

Changes

This allows a schema to be set on the table instead of assuming public.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

PostgreSQL table schema can be set using the DB_SCHEMA environment and configuration variable.
linux-foundation-easycla[bot] commented 11 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

tekton-robot commented 11 months ago

Hi @chriscannon. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chriscannon commented 11 months ago

/kind feature

sayan-biswas commented 11 months ago

/ok-to-test

tekton-robot commented 10 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 11.9% 11.7% -0.2
tekton-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chriscannon commented 10 months ago

@adambkaplan could you also add a lgtm label so that it can pass the CI validation? Thanks!

tekton-robot commented 9 months ago

@chriscannon: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.