handle all terminal states when processing logs

[gabemontero]

Changes

Fixes https://github.com/tektoncd/results/issues/698

/kind bug

The prior check for whether the results Object had completed did not account for objects which had been cancelled. Rather then check every conceivable terminal state, this commit instead makes sure it is not in the Unknown state, which means it has not terminated.

rh-pre-commit.version: 2.1.0 rh-pre-commit.check-secrets: ENABLED

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

• [ n/a] Has Docs included if any changes are user facing
• [n/a ] Has Tests included if any functionality added or changed
• [ /] Tested your changes locally (if this is a code change)
• [ /] Follows the commit message standard
• [/ ] Meets the Tekton contributor standards (including functionality, content, code)
• [ /] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [ /] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [ n/a] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Tekton results will now store logs when the supported runs in question are cancelled

[gabemontero]

/assign @avinal /assign @sayan-biswas

@enarha @ramessesii2 @khrm FYI

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramessesii2, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[khrm]

/cherry-pick release-v0.9.x

[tekton-robot]

@khrm: new pull request created: #701

In response to [this](https://github.com/tektoncd/results/pull/699#issuecomment-1922907009): > >/cherry-pick release-v0.9.x > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.