Closed gabemontero closed 9 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign enarha after the PR has been reviewed.
You can assign the PR to them by writing /assign @enarha
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/dynamic/dynamic.go | 69.3% | 63.4% | -5.9 |
between our stress tests finding some issues with this form of the mem leak fix, and both our stress test and individual testing looking better with our preferred, reduce thread solution in #712 I'm closing this PR.
Changes
multi-threaded alternative to https://github.com/tektoncd/results/pull/712
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes