search

tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Support all data types in summary annotations #722

Closed khrm closed 6 months ago

khrm commented 6 months ago

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

khrm commented 6 months ago

/kind bug

enarha commented 6 months ago

/lgtm

tekton-robot commented 6 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/results/results.go 82.0% 82.5% 0.5
khrm commented 6 months ago

/test pull-tekton-results-unit-tests

khrm commented 6 months ago

/test pull-tekton-results-unit-tests

tekton-robot commented 6 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/results/results.go 82.0% 82.5% 0.5
enarha commented 6 months ago

/lgtm

khrm commented 6 months ago

Fixes #721

tekton-robot commented 6 months ago

@gabemontero: changing LGTM is restricted to collaborators

In response to [this](https://github.com/tektoncd/results/pull/722#pullrequestreview-1917088235): >/lgtm > >including the use of both ints and strings for the third param, which is what lead to our error Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gabemontero commented 6 months ago

ping @khrm @enarha @avinal @sayan-biswas - who wants to apply the approved label?

enarha commented 6 months ago

/approve

tekton-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enarha, gabemontero, ramessesii2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [enarha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 6 months ago

/cherry-pick @release-v0.9.x

tekton-robot commented 6 months ago

@khrm: cannot checkout @release-v0.9.x: error checking out @release-v0.9.x: exit status 1. output: error: pathspec '@release-v0.9.x' did not match any file(s) known to git

In response to [this](https://github.com/tektoncd/results/pull/722#issuecomment-1979181012): >/cherry-pick @release-v0.9.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 6 months ago

/cherry-pick release-v0.9.x

tekton-robot commented 6 months ago

@khrm: new pull request created: #723

In response to [this](https://github.com/tektoncd/results/pull/722#issuecomment-1979184242): >/cherry-pick release-v0.9.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.