tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Disable Proxy for Rest to GRPC communication #727

Closed khrm closed 8 months ago

khrm commented 8 months ago

This is internal communication and proxy isn't needed. Also, GRPC is HTTP/2 and using proxy can cause problem as some of the proxies are HTTP/1.1.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

NONE
khrm commented 8 months ago

/release-note-none

tekton-robot commented 8 months ago

@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to [this](https://github.com/tektoncd/results/pull/727#issuecomment-1991176762): >/release-note-none Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 8 months ago

/assign @sayan-biswas @enarha

khrm commented 8 months ago

This is already shipped in OpenShift Pipelines and we didn't face any issues from the customers. So this approach is correct. Proxy between Rest and GRPC server isn't needed. It's just an internal call.

tekton-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sayan-biswas commented 8 months ago

/lgtm

khrm commented 8 months ago

/cherry-pick release-v0.9.x

tekton-robot commented 8 months ago

@khrm: new pull request created: #734

In response to [this](https://github.com/tektoncd/results/pull/727#issuecomment-2003740824): >/cherry-pick release-v0.9.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.