Closed khrm closed 8 months ago
/release-note-none
@khrm: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".
/assign @sayan-biswas @enarha
This is already shipped in OpenShift Pipelines and we didn't face any issues from the customers. So this approach is correct. Proxy between Rest and GRPC server isn't needed. It's just an internal call.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sayan-biswas
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/cherry-pick release-v0.9.x
@khrm: new pull request created: #734
This is internal communication and proxy isn't needed. Also, GRPC is HTTP/2 and using proxy can cause problem as some of the proxies are HTTP/1.1.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes