tektoncd / results

Long term storage of execution results.
Apache License 2.0
73 stars 69 forks source link

Watcher stores PipelineRun YAML without taskRunTemplate, podTemplate and env vars #730

Open manuelwallrapp opened 3 months ago

manuelwallrapp commented 3 months ago

Expected Behavior

I expect that the PipelineRun YAML are saved completely as it appears in Openshift including the taskRunTemplate. But that is not the case.

kind: "PipelineRun" spec: ...... taskRunTemplate: podTemplate: affinity: nodeAffinity: requiredDuringSchedulingIgnoredDuringExecution: nodeSelectorTerms:

Actual Behavior

the complete taskRunTemplate under the PipelineRun spec is not stored, which makes an exact rerun of the stored YAML difficult. We need to store the taskRunTemplates with its env vars as well.

Steps to Reproduce the Problem

  1. Start a PipelineRun with a defined taskRunTemplate which contains a podTemplate including env vars.
  2. Compare the YAML in Openshift and the YAML in Tekton-Results. The whole taskRunTemplate with podTemplate is missing.

Additional Info

khrm commented 3 months ago

You will find these fields in a different location where they exist in v1beta1.

We need to move to v1 from v1beta1. There's already an issue on that and TEP.

khrm commented 3 months ago

@avinal I assume you will work on v1beta1 to v1 conversion soon? These issues will keep coming up if we don't move to v1 soon.

manuelwallrapp commented 3 months ago

I see, we can not do anything on our side, since our PipelineRuns are using v1 and TektonResults doesn't support yet the full structure of v1 including taskRunTemplate.

khrm commented 3 months ago

@manuelwallrapp Yes, when we move to v1 in Results, it will be resolved.

thomascube commented 2 months ago

I assume #303 is the related issue, right?

khrm commented 1 month ago

Yes. This should be fixed in v0.11.0