tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

WIP: enable pprof via knative in api svr; dump goroutines after long running RPC; optimize k8s client #739

Closed gabemontero closed 5 months ago

gabemontero commented 6 months ago

Changes

/kind misc

Need to be able to profile api server with pprof like we can the watcher (though I'm trying to do it with defaults and not set up the config map watching initially)

Also some production level k8s client tuning that should be fine in developer mode.

Dumping of goroutines on abnormally long GRPC calls.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

pprof now enabled via tekton/knative config map approach
tekton-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign vdemeester after the PR has been reviewed. You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gabemontero commented 6 months ago

@sayan-biswas @khrm @avinal @enarha we'll probably merge some form of this downstream first before merging this PR here but I wanted to see if anything unexpected happened running the build/integration tests here.

tekton-robot commented 6 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 11.9% 10.5% -1.4
tekton-robot commented 6 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 11.9% 10.2% -1.7
gabemontero commented 5 months ago

@sayan-biswas enabled pprof with https://github.com/tektoncd/results/pull/743