tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Update database drivers #742

Closed stuartwdouglas closed 7 months ago

stuartwdouglas commented 7 months ago

Update the database drivers

tekton-robot commented 7 months ago

Hi @stuartwdouglas. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 7 months ago

/release-note-none

gabemontero commented 7 months ago

/assign @khrm /assign @sayan-biswas /assign @avinal /assign @enarha see https://github.com/jackc/pgx/commit/26c79eb215cd1a8022fee209e1df9601626d2f89

what will it take to get this approved / merged?

avinal commented 7 months ago

I will test it today and put my review.

khrm commented 7 months ago

@avinal This updating only vendored code. If there is an issue, it would have been caught by e2e tests.

tekton-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 7 months ago

/kind misc