tektoncd / results

Long term storage of execution results.

Apache License 2.0

77 stars 73 forks source link

Add profiling to API server #743

Closed sayan-biswas closed 6 months ago

sayan-biswas commented 6 months ago

Changes

This feature add golang's native profiling server to expose debug profiles.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[x] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot commented 6 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/api/main.go	11.9%	11.4%	-0.5
pkg/api/server/config/config.go	Do not exist	0.0%

sayan-biswas commented 6 months ago

@gabemontero Here's the PR for enabling basic pprof.

sayan-biswas commented 6 months ago

Although we can port-forward from pod also, I think having it in the service is the right way. I'll make the changes, also fix the lint issue.

tekton-robot commented 6 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/api/main.go	11.9%	11.4%	-0.5
pkg/api/server/config/config.go	Do not exist	0.0%
pkg/api/server/config/config.go	Do not exist	0.0%
pkg/api/server/config/config.go	Do not exist	0.0%
pkg/api/server/config/config.go	Do not exist	0.0%

tekton-robot commented 6 months ago

@gabemontero: changing LGTM is restricted to collaborators

In response to [this](https://github.com/tektoncd/results/pull/743#pullrequestreview-1971120773): >/lgtm > >yeah per the wg call let's start with this vs. the knative approach I tried, and we can iterate on this over time > >next time I get back to api perf testing I hope to try this out, either in conjunction, or as an alternative to, my temporary thread dumps in known problematic calls like ListRecords or UpdateLogs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

khrm commented 6 months ago

@enarha Let's merge this.

tekton-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, gabemontero, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal,khrm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment