Closed khrm closed 6 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
/hold
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 20.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 28.6% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/watcher/reconciler/dynamic/dynamic.go | 64.2% | 60.3% | -3.9 |
pkg/watcher/results/eventset.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 20.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | 100.0% | 28.6% | -71.4 |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/watcher/reconciler/dynamic/dynamic.go | 64.2% | 59.4% | -4.8 |
pkg/watcher/results/eventset.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 20.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | 100.0% | 20.0% | -80.0 |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 66.7% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/watcher/reconciler/dynamic/dynamic.go | 64.2% | 59.4% | -4.8 |
pkg/watcher/results/eventlist.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 20.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | 100.0% | 28.6% | -71.4 |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/watcher/reconciler/dynamic/dynamic.go | 64.2% | 59.4% | -4.8 |
pkg/watcher/results/eventlist.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 20.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 33.3% | |
pkg/watcher/reconciler/dynamic/dynamic.go | 64.2% | 59.4% | -4.8 |
pkg/watcher/results/eventlist.go | Do not exist | 0.0% |
/test pull-tekton-results-integration-tests
/test pull-tekton-results-integration-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 20.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | 100.0% | 0.0% | -100.0 |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 37.5% | |
pkg/watcher/reconciler/dynamic/dynamic.go | 64.2% | 59.6% | -4.6 |
pkg/watcher/results/eventlist.go | Do not exist | 0.0% |
/kind feature
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 20.0% | |
pkg/api/server/v1alpha2/eventlist/eventset.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | 100.0% | 28.6% | -71.4 |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 0.0% | |
pkg/apis/v1alpha2/types.go | Do not exist | 100.0% | |
pkg/watcher/reconciler/dynamic/dynamic.go | 64.2% | 59.6% | -4.6 |
pkg/watcher/results/eventlist.go | Do not exist | 0.0% |
This could work without an API.
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
/test pull-tekton-results-build-tests
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
@khrm: PR needs rebase.
Not that I am an SME in all the areas you changed @khrm , but if you rebase this (needs a rebase) I'll review this week.
Minimally I'll ping those SMEs I think can chime in if I see an area I am uncertain about.
Thanks.
I should close this PR. There's another one that I open. This one was only POC.
Events are stored when we are done with Runs and in a single List.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes