tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

WIP: POC for Storing List of Events #745

Closed khrm closed 6 months ago

khrm commented 7 months ago

Events are stored when we are done with Runs and in a single List.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

tekton-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 7 months ago

/hold

tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/apis/v1alpha2/types.go Do not exist 28.6%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 60.3% -3.9
pkg/watcher/results/eventset.go Do not exist 0.0%
tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go 100.0% 28.6% -71.4
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.4% -4.8
pkg/watcher/results/eventset.go Do not exist 0.0%
tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go 100.0% 20.0% -80.0
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 66.7%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.4% -4.8
pkg/watcher/results/eventlist.go Do not exist 0.0%
tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go 100.0% 28.6% -71.4
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.4% -4.8
pkg/watcher/results/eventlist.go Do not exist 0.0%
tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 33.3%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.4% -4.8
pkg/watcher/results/eventlist.go Do not exist 0.0%
khrm commented 7 months ago

/test pull-tekton-results-integration-tests

khrm commented 7 months ago

/test pull-tekton-results-integration-tests

tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go 100.0% 0.0% -100.0
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 37.5%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.6% -4.6
pkg/watcher/results/eventlist.go Do not exist 0.0%
khrm commented 7 months ago

/kind feature

tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go 100.0% 28.6% -71.4
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.6% -4.6
pkg/watcher/results/eventlist.go Do not exist 0.0%
khrm commented 7 months ago

This could work without an API.

tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 11.4% 11.2% -0.2
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/events.go Do not exist 0.0%
pkg/api/server/v1alpha2/lister/lister.go 15.8% 15.5% -0.3
pkg/apis/v1alpha2/types.go 100.0% 0.0% -100.0
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.6% -4.6
pkg/watcher/results/eventlist.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 7 months ago

/test pull-tekton-results-build-tests

khrm commented 7 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 11.4% 11.2% -0.2
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/events.go Do not exist 0.0%
pkg/api/server/v1alpha2/lister/lister.go 15.8% 15.5% -0.3
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.6% -4.6
pkg/watcher/results/eventlist.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 7 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 7 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 11.4% 11.2% -0.2
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 0.0%
pkg/api/server/v1alpha2/eventlist/eventset.go Do not exist 20.0%
pkg/api/server/v1alpha2/events.go Do not exist 0.0%
pkg/api/server/v1alpha2/lister/lister.go 15.8% 15.5% -0.3
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 0.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/apis/v1alpha2/types.go Do not exist 100.0%
pkg/watcher/reconciler/dynamic/dynamic.go 64.2% 59.6% -4.6
pkg/watcher/results/eventlist.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
tekton-robot commented 7 months ago

@khrm: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gabemontero commented 6 months ago

Not that I am an SME in all the areas you changed @khrm , but if you rebase this (needs a rebase) I'll review this week.

Minimally I'll ping those SMEs I think can chime in if I see an area I am uncertain about.

Thanks.

khrm commented 6 months ago

I should close this PR. There's another one that I open. This one was only POC.