Closed khrm closed 2 months ago
/hold
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-build-tests
/test pull-tekton-results-unit-tests
/test pull-tekton-results-integration-tests
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-build-tests
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-build-tests
/test pull-tekton-results-build-tests
/test pull-tekton-results-build-tests
/test pull-tekton-results-unit-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/log/s3.go | 38.2% | 0.0% | -38.2 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-unit-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-integration-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-integration-tests
/test pull-tekton-results-integration-tests
e2e tests are passing locally. I upgraded kind version to resolve this.
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/v1alpha2/logs.go | 62.0% | 56.5% | -5.6 |
pkg/api/server/v1alpha2/records.go | 87.1% | 52.5% | -34.7 |
pkg/watcher/reconciler/pipelinerun/reconciler.go | 45.3% | 41.9% | -3.4 |
pkg/watcher/results/results.go | 82.5% | 77.7% | -4.9 |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% | |
proto/v1alpha2/results_go_proto/api.pb.gw.go | Do not exist | 0.0% |
/test pull-tekton-results-unit-tests
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
/test pull-tekton-results-unit-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
/test pull-tekton-results-build-tests
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
@avinal @enarha @vdemeester
Let's review and merge this.
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
@vdemeester @avinal @enarha Let's try to merge this.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes
Add support for storing PipelineRun and TaskRun objects as v1. These CRs are reconciled as the v1 version of Pipelines API and then stored in DB as v1. Existing v1beta1 resources are kept as it is. An ability to convert these older records to v1 will be added.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes