tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Add Support for Tekton Pipeline v1 APIs #762

Closed khrm closed 2 months ago

khrm commented 3 months ago

Changes

Add support for storing PipelineRun and TaskRun objects as v1. These CRs are reconciled as the v1 version of Pipelines API and then stored in DB as v1. Existing v1beta1 resources are kept as it is. An ability to convert these older records to v1 will be added.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Records of TaskRuns and PipelineRuns are as stored as v1 in db instead of v1beta1.
Add support for storing PipelineRun and TaskRun objects as v1.
These CRs are reconciled as the v1 version of Pipelines API and then
stored in DB as v1. Existing v1beta1 resources are kept as it is.
khrm commented 3 months ago

/hold

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-build-tests

khrm commented 3 months ago

/test pull-tekton-results-unit-tests

khrm commented 3 months ago

/test pull-tekton-results-integration-tests

khrm commented 3 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-build-tests

khrm commented 3 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-build-tests

khrm commented 3 months ago

/test pull-tekton-results-build-tests

khrm commented 3 months ago

/test pull-tekton-results-build-tests

khrm commented 3 months ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-integration-tests

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 3 months ago

/test pull-tekton-results-integration-tests

khrm commented 3 months ago

/test pull-tekton-results-integration-tests

khrm commented 3 months ago

e2e tests are passing locally. I upgraded kind version to resolve this.

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/logs.go 62.0% 56.5% -5.6
pkg/api/server/v1alpha2/records.go 87.1% 52.5% -34.7
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
pkg/watcher/results/results.go 82.5% 77.7% -4.9
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 2 months ago

/test pull-tekton-results-unit-tests

khrm commented 2 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 2 months ago

/test pull-tekton-results-unit-tests

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 2 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 2 months ago

/test pull-tekton-results-build-tests

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 2 months ago

@avinal @enarha @vdemeester

Let's review and merge this.

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
khrm commented 2 months ago

@vdemeester @avinal @enarha Let's try to merge this.

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment