tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Change kind Role to ClusterRole for tekton-results-readonly #780

Closed pawelkopka closed 3 months ago

pawelkopka commented 3 months ago

In release there isn't Role tekton-results-readonly, but there is ClusterRole

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

tekton-robot commented 3 months ago

Hi @pawelkopka. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 3 months ago

/kind documentation

khrm commented 3 months ago

@pawelkopka Please sign the cla.

pawelkopka commented 3 months ago

@pawelkopka Please sign the cla.

done :)

tekton-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 3 months ago

/release-note-none