tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Add Support for fetching forwarded logs from third party API #782

Closed khrm closed 3 weeks ago

khrm commented 1 month ago

This enables the support for fetching logs from Third Party API. This pr enables the support for Lokistack logs which are forwarded using vector, fluentbit or fluentd.

Other stack like ELK, splunk, etc can be added later on.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Enables the support for fetching logs from Third Party API. We have enabled the support for Loki for now. Later on, support for other logging stacks like Splunk, Google Cloud Logging, etc can be added.
tekton-robot commented 4 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.6% -0.4
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 72.0% 3.8
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
khrm commented 4 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 4 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.6% -0.4
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 72.0% 3.8
pkg/apis/v1alpha3/types.go 100.0% 0.0% -100.0
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
khrm commented 4 weeks ago

/test pull-tekton-results-unit-tests

khrm commented 4 weeks ago

/hold cancel Pipelines release v0.63 was done.

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.6% -0.4
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 72.0% 3.8
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.6% -0.4
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 72.0% 3.8
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

khrm commented 3 weeks ago

/hold Let me do some final testing and then we can merge.

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.6% -0.4
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 69.2% 1.0
pkg/apis/v1alpha3/types.go 100.0% 0.0% -100.0
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.6% -0.4
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 71.2% 3.0
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.3% -0.7
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 73.6% 5.4
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

khrm commented 3 weeks ago

image Done with testing GRPC endpoints. Now testing Rest API end point.

khrm commented 3 weeks ago

REST API endpoints are also working fine: image

khrm commented 3 weeks ago

/hold cancel

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.3% -0.7
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 73.6% 5.4
pkg/apis/v1alpha3/types.go 100.0% 0.0% -100.0
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
tekton-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 3 weeks ago

@khrm I have no other comments and I'm ready to lgtm this change. You mentioned above you are going to add another update based on Avinal's comment. Once you are ready, I'll lgtm. Otherwise it'll be removed on update or merge automatically before.

khrm commented 3 weeks ago

/retest

khrm commented 3 weeks ago

@enarha I have updated with that change.

khrm commented 3 weeks ago

https://github.com/tektoncd/results/compare/802dda3b5d5e1b5f0b8ae2f9495ba692d714d69a..7b361fb4536eab682abd461a9adf42280029065b

enarha commented 3 weeks ago

/lgtm

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/api/main.go 9.0% 8.3% -0.7
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go Do not exist 60.9%
pkg/api/server/v1alpha2/server.go 68.2% 73.6% 5.4
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/apis/v1alpha3/types.go Do not exist 100.0%
pkg/apis/v1alpha3/types.go Do not exist 0.0%
pkg/cli/client/client.go 19.4% 15.0% -4.4
pkg/cli/cmd/logs/get.go Do not exist 0.0%
pkg/cli/config/config.go 46.4% 48.3% 1.8
pkg/cli/flags/flags.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%
proto/v1alpha3/results_go_proto/log.pb.gw.go Do not exist 0.0%