khrm commented 3 months ago

Add Result Retention Policy Agent which removes older Result and their associated records. Retention Policy is based on the configmap config-results-retention-policy.yaml

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add Result Retention Policy Agent which removes older Result and their associated records.

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	0.0%

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	0.0%

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	0.0%

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	0.0%

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	0.0%

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	0.0%

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	0.0%

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	38.9%

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	38.9%

khrm commented 2 months ago

/test pull-tekton-results-unit-tests

khrm commented 2 months ago

/test pull-tekton-results-unit-tests

khrm commented 2 months ago

/test pull-tekton-results-unit-tests

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	38.9%

khrm commented 2 months ago

Checking for flakiness by retesting again. 3 previous runs passed. /test pull-tekton-results-unit-tests

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	38.9%

khrm commented 2 months ago

I have addressed all review comments @enarha

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
cmd/retention-policy-agent/main.go	Do not exist	0.0%
pkg/apis/config/retention.go	Do not exist	10.5%
pkg/retention/config.go	Do not exist	0.0%
pkg/retention/job.go	Do not exist	38.9%

enarha commented 2 months ago

/lgtm

tektoncd / results

Add Global Retention Policy Agent for DB #784

Changes

Submitter Checklist

Release Notes