khrm commented 3 weeks ago

Added finalizer to TaskRun and PipelineRun to ensure that TaskRun and PipelienRun are stored. This will block deletion until the deadline (Completion + store_deadline) lapses or Runs are stored when done.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Added finalizer to TaskRun and PipelineRun to ensure that TaskRun and PipelienRun are stored. This will block deletion until the deadline (Completion + store_deadline) lapses or Runs are stored when done.
This finalizer doesn't block if log streaming from watcher or pruner is enabled.

khrm commented 3 weeks ago

/kind bug

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	58.2%	2.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	34.6%	-7.2

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	58.2%	2.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	33.3%	-8.5

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	58.1%	1.9
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	33.3%	-8.5

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	58.0%	1.8
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	32.1%	-9.7

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	58.0%	1.8
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	32.1%	-9.7

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.5%	-5.7
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	32.1%	-9.7

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.5%	-5.7
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	32.1%	-9.7

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.5%	-5.7
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	32.1%	-9.7

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.3%	-5.9
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	32.1%	-9.7

tekton-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.5%	-5.7
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

khrm commented 3 weeks ago

/test pull-tekton-results-build-tests

khrm commented 3 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

khrm commented 3 weeks ago

/test pull-tekton-results-integration-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

khrm commented 3 weeks ago

/test pull-tekton-results-integration-tests

tekton-robot commented 3 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

khrm commented 3 weeks ago

/assign @enarha

tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

khrm commented 2 weeks ago

/test pull-tekton-results-integration-tests

khrm commented 2 weeks ago

/test pull-tekton-results-unit-tests

tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

tekton-robot commented 2 weeks ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/watcher/reconciler/dynamic/dynamic.go	56.2%	50.2%	-6.0
pkg/watcher/reconciler/pipelinerun/reconciler.go	41.9%	30.5%	-11.4

enarha commented 2 weeks ago

/lgtm

tektoncd / results

Add finalizer to ensure that Runs are stored #797

Changes

Submitter Checklist

Release Notes