tektoncd / results

Long term storage of execution results.

Apache License 2.0

78 stars 74 forks source link

Pass Record name to the v1alpha3 API in tkn-results cli #818

Closed khrm closed 1 month ago

khrm commented 2 months ago

Now user can pass the record name in the below format to v1alpha3 GetLog : <namespace>/results/<parent-run-uuid>/records/<child-run-uuid>

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Tested your changes locally (if this is a code change)
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

User can pass the record name in the below format to v1alpha3 GetLog :
<namespace>/results/<parent-run-uuid>/records/<child-run-uuid>

khrm commented 2 months ago

/test pull-tekton-results-build-tests

khrm commented 2 months ago

/retest

khrm commented 2 months ago

/test pull-tekton-results-build-tests

khrm commented 2 months ago

/assign @enarha

khrm commented 1 month ago

/cherry-pick release-v0.11.x

tekton-robot commented 1 month ago

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.11.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/results/pull/818#issuecomment-2363193486): >/cherry-pick release-v0.11.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

khrm commented 1 month ago

/cherry-pick release-v0.12.x

tekton-robot commented 1 month ago

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.12.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/results/pull/818#issuecomment-2363193946): > >/cherry-pick release-v0.12.x > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

vdemeester commented 1 month ago

/approve /lgtm

tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tekton-robot commented 1 month ago

@khrm: #818 failed to apply on top of branch "release-v0.11.x":

Applying: Pass Record name to the v1alpha3 API in tkn-results cli
Using index info to reconstruct a base tree...
M   pkg/cli/cmd/logs/get.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cli/cmd/logs/get.go
CONFLICT (content): Merge conflict in pkg/cli/cmd/logs/get.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Pass Record name to the v1alpha3 API in tkn-results cli
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/tektoncd/results/pull/818#issuecomment-2363193486): >/cherry-pick release-v0.11.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tekton-robot commented 1 month ago

@khrm: cannot checkout release-v0.12.x: error checking out release-v0.12.x: exit status 1. output: error: pathspec 'release-v0.12.x' did not match any file(s) known to git

In response to [this](https://github.com/tektoncd/results/pull/818#issuecomment-2363193946): > >/cherry-pick release-v0.12.x > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

khrm commented 1 month ago

/cherry-pick release-v0.12.x

tekton-robot commented 1 month ago

@khrm: new pull request created: #819

In response to [this](https://github.com/tektoncd/results/pull/818#issuecomment-2363208124): > >/cherry-pick release-v0.12.x > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.