tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Provide QueryLimit options for Third Party Logs API (Loki) #823

Closed khrm closed 2 months ago

khrm commented 2 months ago

This adds a new config to provide a query limit for Third Party Logging API.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

This adds a new config to provide a query limit for Third Party Logging API.: LOGGING_PLUGIN_QUERY_LIMIT
khrm commented 2 months ago

/retest

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go 47.7% 48.2% 0.5
pkg/api/server/v1alpha2/server.go 73.9% 74.5% 0.6
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go 47.7% 48.2% 0.5
pkg/api/server/v1alpha2/server.go 73.9% 74.5% 0.6
tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 2 months ago

Why do we need that limit? Is that a limit on numbers of lines to be returned by the logging backend?

khrm commented 2 months ago

@enarha Yes. By default, the limit is only 100.

khrm commented 2 months ago

/retest

khrm commented 2 months ago

Changed the documentation, please relook. @enarha

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/config/config.go Do not exist 0.0%
pkg/api/server/v1alpha2/plugin_logs.go 47.7% 48.2% 0.5
pkg/api/server/v1alpha2/server.go 73.9% 74.5% 0.6
khrm commented 2 months ago

/cherry-pick release-v0.12.x

tekton-robot commented 2 months ago

@khrm: new pull request created: #824

In response to [this](https://github.com/tektoncd/results/pull/823#issuecomment-2368366592): >/cherry-pick release-v0.12.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.