Closed khrm closed 2 months ago
/retest
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/config/config.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/plugin_logs.go | 47.7% | 48.2% | 0.5 |
pkg/api/server/v1alpha2/server.go | 73.9% | 74.5% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/config/config.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/plugin_logs.go | 47.7% | 48.2% | 0.5 |
pkg/api/server/v1alpha2/server.go | 73.9% | 74.5% | 0.6 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Why do we need that limit? Is that a limit on numbers of lines to be returned by the logging backend?
@enarha Yes. By default, the limit is only 100.
/retest
Changed the documentation, please relook. @enarha
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/api/server/config/config.go | Do not exist | 0.0% | |
pkg/api/server/v1alpha2/plugin_logs.go | 47.7% | 48.2% | 0.5 |
pkg/api/server/v1alpha2/server.go | 73.9% | 74.5% | 0.6 |
/cherry-pick release-v0.12.x
@khrm: new pull request created: #824
This adds a new config to provide a query limit for Third Party Logging API.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes