tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Add nil Check for Completion time in Finalizer #859

Closed khrm closed 1 month ago

khrm commented 1 month ago

There are cases when TaskRun don't have completion time. e.g. : CreateContainerConfigError

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

khrm commented 1 month ago

/cherry-pick release-v0.12.x

tekton-robot commented 1 month ago

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.12.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/results/pull/859#issuecomment-2429440042): >/cherry-pick release-v0.12.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 1 month ago

/assign @vdemeester

khrm commented 1 month ago

/assign @enarha

khrm commented 1 month ago

/assign @avinal

tekton-robot commented 1 month ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 30.5% 29.0% -1.5
tekton-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 1 month ago

@khrm: new pull request created: #860

In response to [this](https://github.com/tektoncd/results/pull/859#issuecomment-2429440042): >/cherry-pick release-v0.12.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.