tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Fix Panic in the API server #870

Closed khrm closed 2 weeks ago

khrm commented 2 weeks ago

API server gets panic under certain negative scenarios. We fixed that by creating a new variable for error.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

khrm commented 2 weeks ago

/assign @enarha @vdemeester

tekton-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 2 weeks ago

/lgtm

khrm commented 2 weeks ago

/chery-pick @release-v0.12.x

khrm commented 2 weeks ago

/chery-pick release-v0.12.x

khrm commented 2 weeks ago

/cherry-pick release-v0.12.x

tekton-robot commented 2 weeks ago

@khrm: new pull request created: #872

In response to [this](https://github.com/tektoncd/results/pull/870#issuecomment-2455242988): >/cherry-pick release-v0.12.x > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 2 weeks ago

/cherry-pick release-v0.12.x

tekton-robot commented 2 weeks ago

@khrm: new pull request could not be created: failed to create pull request against tektoncd/results#release-v0.12.x from head tekton-robot:cherry-pick-870-to-release-v0.12.x: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for tekton-robot:cherry-pick-870-to-release-v0.12.x."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to [this](https://github.com/tektoncd/results/pull/870#issuecomment-2455245173): > >/cherry-pick release-v0.12.x > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.