search

tektoncd / results

Long term storage of execution results.
Apache License 2.0
78 stars 74 forks source link

Enable Finalizer for Pruner - Grace Period Config #888

Closed khrm closed 6 days ago

khrm commented 6 days ago

Finalizer was disabled earlier for pruner setting, this enables it.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Enable Finalizer for Pruner - Grace Period Config
tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 50.2% 50.7% 0.5
pkg/watcher/reconciler/pipelinerun/reconciler.go 28.6% 29.5% 0.9
khrm commented 6 days ago

/test pull-tekton-results-integration-tests

tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 50.2% 50.7% 0.5
pkg/watcher/reconciler/pipelinerun/reconciler.go 28.6% 29.5% 0.9
khrm commented 6 days ago

/test pull-tekton-results-integration-tests

tekton-robot commented 6 days ago

The following is the coverage report on the affected files. Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/dynamic/dynamic.go 50.2% 50.7% 0.5
pkg/watcher/reconciler/pipelinerun/reconciler.go 28.6% 29.5% 0.9
khrm commented 6 days ago

/test pull-tekton-results-integration-tests

khrm commented 6 days ago

/assign @vdemeester @enarha

khrm commented 6 days ago

/cherry-pick @release-v0.12.x

tekton-robot commented 6 days ago

@khrm: once the present PR merges, I will cherry-pick it on top of @release-v0.12.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/results/pull/888#issuecomment-2485605564): >/cherry-pick @release-v0.12.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal,vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 6 days ago

@khrm: cannot checkout @release-v0.12.x: error checking out @release-v0.12.x: exit status 1. output: error: pathspec '@release-v0.12.x' did not match any file(s) known to git

In response to [this](https://github.com/tektoncd/results/pull/888#issuecomment-2485605564): >/cherry-pick @release-v0.12.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 5 days ago

/cherry-pick release-v0.12.x

tekton-robot commented 5 days ago

@khrm: new pull request created: #890

In response to [this](https://github.com/tektoncd/results/pull/888#issuecomment-2487946757): > >/cherry-pick release-v0.12.x > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.