tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
557 stars 420 forks source link

slack interceptors - EventListeners removes form part of the request payload #1526

Closed ilan-pinto closed 1 year ago

ilan-pinto commented 1 year ago

Expected Behavior

While working on a slack custom interceptor, I discovered that InterceptorRequest doesn't pass HTTP form data

given the fact that Slack "slash commands" sends form data over HTTP form. it prevents integrating Slack "slash commands" with Tekton

Actual Behavior

event listner should not commit form and if possible transform it to json

Steps to Reproduce the Problem

a dummy env could be created using kind following this repo

Additional Info

Tekton Pipelines: v0.41.0 Tekton Triggers: v0.22.0 Kubernetes version v1.24.6

ilan-pinto commented 1 year ago

/assign ilan-pinto

dibyom commented 1 year ago

yeah the initial design for InterceptorRequest assumed JSON body (since trigger bindings assume JSON). I think we could add a new field for passing FormData if it exists? What do you think?

khrm commented 1 year ago

Should we close this issue as done, @ilan-pinto ?

ilan-pinto commented 1 year ago

yes