Closed kcloutie closed 1 year ago
@kcloutie: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign savitaashture after the PR has been reviewed.
You can assign the PR to them by writing /assign @savitaashture
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @kcloutie. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Changes
Moved types used by interceptors from
trigger_types.go
to the interceptors specific implementation as requested in PR #1507 and issues #1513Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them: