tektoncd / triggers

Event triggering with Tekton!

Apache License 2.0

557 stars 419 forks source link

`githubOwners` and `addChangedFiles` do not work together when the `eventType` is `issue_comment` #1572

Open VeereshAradhya opened 1 year ago

VeereshAradhya commented 1 year ago

Expected Behavior

Taskrun/pipelinerun should get created when a comment /ok-to-test is commented

Actual Behavior

Taskrun/pipelinerun not getting created when a comment /ok-to-test is commented

Steps to Reproduce the Problem

Create a repository
Create an event listener with github interceptor with params githubOwners, addChangedFiles, and eventType (pull_request, issue_comment)
Create a PR from a different account which is not listed in OWNERS file
Comment /ok-to-test on the pull request

Additional Info

Kubernetes version:

Output of kubectl version:

Client Version: v1.25.7
Kustomize Version: v4.5.7
Server Version: v1.24.11+af0420d

Tekton Pipeline version:

Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'
```
Client version: 0.30.0
Pipeline version: v0.44.0
Triggers version: v0.23.0
Operator version: v0.65.1
```

savitaashture commented 1 year ago

/assign @kcloutie

tekton-robot commented 1 year ago

@savitaashture: GitHub didn't allow me to assign the following users: kcloutie.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/tektoncd/triggers/issues/1572#issuecomment-1513238875): >/assign @kcloutie Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tekton-robot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot commented 1 year ago

@tekton-robot: Closing this issue.

In response to [this](https://github.com/tektoncd/triggers/issues/1572#issuecomment-1721456002): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen` with a justification. >Mark the issue as fresh with `/remove-lifecycle rotten` with a justification. >If this issue should be exempted, mark the issue as frozen with `/lifecycle frozen` with a justification. > >/close > >Send feedback to [tektoncd/plumbing](https://github.com/tektoncd/plumbing). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

khrm commented 1 year ago

/remove-lifecycle rotten

We need to fix this in future.

khrm commented 1 year ago

/reopen

tekton-robot commented 1 year ago

@khrm: Reopened this issue.

In response to [this](https://github.com/tektoncd/triggers/issues/1572#issuecomment-1721491149): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.