tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
557 stars 420 forks source link

Add Annotation to integrate Triggers with Results #1575

Open khrm opened 1 year ago

khrm commented 1 year ago

Feature request

We suggest adding the following annotations:

1. 
  annotations:
    results.tekton.dev/resultAnnotations: |-
      {"repo": "tektoncd/results", "commit": "1a6b908", eventType:"pr", "pull_request-id"}
    results.tekton.dev/recordSummaryAnnotations: |-
      {"repo": "tektoncd/results", "commit": "1a6b908", eventType: "pull_request-id"}
 2. 
   annotations:
    results.tekton.dev/resultAnnotations: |-
      {"repo": "tektoncd/results", "commit": "1a6b908", eventType:"push"}
    results.tekton.dev/recordSummaryAnnotations: |-
      {"repo": "tektoncd/results", "commit": "1a6b908", eventType:-"push"}

Use case

Tekton results will store these fields in Summary and Record as Annotations. By default, Pipelinerun metadata information is JSON + base64 encoded. And in pipeline list APIs, we don't have information on what triggered the pipelines. This field will be utilized by Dashboard/CLI clients to show the relevant data.

khrm commented 1 year ago

/assign

tekton-robot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot commented 1 year ago

@tekton-robot: Closing this issue.

In response to [this](https://github.com/tektoncd/triggers/issues/1575#issuecomment-1713768584): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen` with a justification. >Mark the issue as fresh with `/remove-lifecycle rotten` with a justification. >If this issue should be exempted, mark the issue as frozen with `/lifecycle frozen` with a justification. > >/close > >Send feedback to [tektoncd/plumbing](https://github.com/tektoncd/plumbing). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 1 year ago

/remove-lifecycle rotten

We need this feature.

khrm commented 1 year ago

/reopen

tekton-robot commented 1 year ago

@khrm: Reopened this issue.

In response to [this](https://github.com/tektoncd/triggers/issues/1575#issuecomment-1713770263): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.