tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
557 stars 419 forks source link

Remove comparing serviceaccount in tests #1576

Closed piyush-garg closed 1 year ago

piyush-garg commented 1 year ago

This will remove comparing service account in eventlistener create test as the default serviceaccount can be different on different platforms like operator on OpenShift

This remove the serviceaccount field from expected output and also add ignore field in cmp.Diff

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Release Notes

Remove comparing serviceaccount in tests
khrm commented 1 year ago

/kind cleanup

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment