Open waltforme opened 1 year ago
@tektoncd/triggers-maintainers Should the getting-started doc in the Triggers repo be removed? It looks like the content of the readme hasn't been updated in 2 years.
The Triggers getting started guide displayed on the website comes from the website repo instead and was added at the end of 2022: https://github.com/tektoncd/website/blob/main/content/en/docs/Getting-started/triggers.md
It could be confusing having 2 different versions, as it's not immediately clear to users which is correct / current.
Expected Behavior
The
roleRef
of thetekton-triggers-getting-started-clusterbinding
clusterrolebinding in docs/getting-started/rbac/clusterrolebinding.yaml refers to some real clusterrole.Actual Behavior
The
roleRef
refers to a clusterroletekton-triggers-example-clusterrole
which doesn't exist.Steps to Reproduce the Problem
tekton-triggers-example-clusterrole
only appears once in this repository.tekton-triggers-example-clusterrole
doesn't exist in a cluster with Tekton Pipelines and Tekton Triggers installed.Additional Info
Kubernetes version:
Output of
kubectl version
:Tekton Pipeline version:
Client version: 0.26.0 Pipeline version: v0.40.0 Triggers version: v0.21.0
The tutorial documented by
docs/getting-started/README.md
works anyway, even if the clusterroletekton-triggers-example-clusterrole
doesn't exist.docs/getting-started/README.md
instructs readers to delete thegetting-started
namespace for cleaning up. But the cluster scoped RBAC objects, e.g. clusterrolebindings, won't get cleaned.I can see the the Tekton website is not using
docs/getting-started
, but I guess there is not harm to fix it :)