tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

drop manual use of knative.dev/pkg::injection.Dynamic #1594

Closed dprotaso closed 1 year ago

dprotaso commented 1 year ago

Changes

Fixes: https://github.com/tektoncd/triggers/issues/1593

Upstream Knative is maintaining some codegen to faciliate a k8s dynamic.Client being the underlying implementation of a kubernetes.Interface

It turns out it doesn't really have any usage except for this repo.

We're looking to remove this functionality - (discussion https://github.com/knative/pkg/issues/2739#issuecomment-1550452957)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 1 year ago

Hi @dprotaso. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
imjasonh commented 1 year ago

/ok-to-test

tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/metrics/injection.go 45.5% 44.4% -1.0
pkg/sink/cloudevent/cloudeventclient.go 11.1% 5.9% -5.2
tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dibyom commented 1 year ago

/cc @khrm @savitaashture

savitaashture commented 1 year ago

/lgtm

:+1: