search

tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

CE response from sink fails for the Eventing MT ingress broker #1599

Closed khrm closed 1 year ago

khrm commented 1 year ago

Expected Behavior

CE response type should work with https://github.com/knative/eventing/blob/main/docs/broker/README.md

Actual Behavior

Because type is empty, we get:

{"level":"warn","ts":"2023-05-29T21:39:29.919Z","logger":"mt_broker_ingress","caller":"ingress/ingress_handler.go:146","msg":"failed to validate extracted event","commit":"034bec9","error":"type: MUST be a non-empty string\n"}
khrm commented 1 year ago

/assign @khrm

khrm commented 1 year ago

@afrittoli Created #1600 to fix this

khrm commented 1 year ago

/cherry-pick release-0.24.x