Closed khrm closed 1 year ago
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/adapter/adapter.go | 23.5% | 22.6% | -0.8 |
/test tekton-triggers-unit-tests
@dibyom There's a bug in sending k8s events but I don't have any idea why were are encountering it now after merging #1584 .
Fixes #1602
Tested with the fix I see events are coming
$ oc get events | grep "dev.tekton.event.triggers" -w
3s Normal dev.tekton.event.triggers.started.v1 eventlistener/github-listener
3s Normal dev.tekton.event.triggers.done.v1 eventlistener/github-listener
3s Normal dev.tekton.event.triggers.successful.v1 eventlistener/github-listener
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: savitaashture
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/cherry-pick release-0.24.x
@khrm: once the present PR merges, I will cherry-pick it on top of release-0.24.x in a new PR and assign it to you.
@khrm: cannot checkout release-0.24.x
: error checking out release-0.24.x: exit status 1. output: error: pathspec 'release-0.24.x' did not match any file(s) known to git
/cherry-pick release-v0.24.x
@khrm: new pull request created: #1604
We spent a whole day to bisect this bug right after cluster upgrade via tekton operator. It would be better to call out the packaging side as it's still deployable for many users.
By the way, how the scheme addition solve this problem? (Out of curiousity)
After pr #1584, k8s events is not coming. This fixes that by adding v1beta1 and v1alpha1 apis to scheme.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes